macdoor opened a new pull request, #18693:
URL: https://github.com/apache/dolphinscheduler/pull/18693
## Was this PR generated or assisted by AI?
**YES** — the SQL Gateway submit path, UI fields, and unit tests were
assisted by an AI agent (Hermes). The change was human-reviewed. Unit tests
passed, and a FLINK task with `sqlSubmitType=SQL_GATEWAY` was smoked on an
internal cluster.
## Purpose of the pull request
Add an optional SQL Gateway submit mode to the existing **FLINK** task, so
batch SQL can be sent to a remote Flink SQL Gateway over JDBC without a local
Flink client.
This follows the review on #18690: do not add a new task type. The existing
`sql-client.sh` path stays the default. Closes #18691.
## Brief change log
- `FlinkParameters.sqlSubmitType`: absent / `CLIENT` keeps
`${FLINK_HOME}/bin/sql-client.sh`; `SQL_GATEWAY` submits over JDBC and cancels
via `statement.cancel()`
- Fork only at `FlinkTask.handle()` / `cancelApplication()`. `getScript()`
and `FlinkArgsUtils` are unchanged
- Script sources reuse `SqlSourceType`. The JDBC driver is shaded only into
`dolphinscheduler-task-flink`; `dolphinscheduler-task-flink-stream` excludes it
- UI shows the Gateway fields only when program type is SQL and submit type
is SQL Gateway
## Verify this pull request
This change added tests and can be verified as follows:
- `mvn test -pl dolphinscheduler-task-plugin/dolphinscheduler-task-flink
-Dtest=FlinkParametersTest,FlinkSqlGatewayExecutorTest,FlinkArgsUtilsTest,FlinkTaskTest
-Dspotless.skip=true -Djacoco.skip=true`
- `mvn -pl
dolphinscheduler-task-plugin/dolphinscheduler-task-flink,dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream
spotless:check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
