macdoor commented on PR #18693: URL: https://github.com/apache/dolphinscheduler/pull/18693#issuecomment-6118437528
Addressed the review on ea309e3d66. 1. The executor adds `SET 'table.dml-sync'='true'` itself, before the init script and the main script. This is not a Gateway default and is not left to user SQL. With that flag, DML blocks until the job reaches a terminal state. A later job failure is thrown by the driver and the task is marked FAILURE, not SUCCESS. We do not poll the JobManager. 2. A kill during `getConnection()` is published under a lock and is not overwritten with SUCCESS. 3. Statement splitting skips separators inside quotes, escaped quotes, and `--` / `/* */` comments. Covered by unit tests. 4. `SQL_GATEWAY` is accepted only when `programType` is SQL. Leaving SQL serializes `sqlSubmitType` as `CLIENT`. 5. Gateway controls are shown only for `taskType=FLINK`, not `FLINK_STREAM`. 6. `flink-sql-jdbc-driver-bundle` 2.2.0 is Java 11 bytecode. `SQL_GATEWAY` fails in init on JDK 8 and states that JDK 11+ is required. The official bundle is provided on the classpath and is not shaded into the plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
