njnu-seafish commented on code in PR #18549: URL: https://github.com/apache/dolphinscheduler/pull/18549#discussion_r4237139706
########## dolphinscheduler-dao/src/main/resources/sql/upgrade/3.5.0_schema/mysql/dolphinscheduler_ddl.sql: ########## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +-- If the table already has duplicate rows, index creation will fail; resolve them manually first. +ALTER TABLE `t_ds_alert` ADD UNIQUE INDEX `uk_alert_dedup` (`sign`, `workflow_instance_id`, `alert_type`); Review Comment: > We don't need to add a unique index here, use sign is enouth, we need to make sure differenct alert has different sign. Good point — the 3-column unique index was over-constrained. The task-result sign already embeds the task instance id (sha1(taskInstanceId + "|" + content)), so the same task's repeated success maps to the same sign while different tasks never collide even with identical results. I've simplified the unique constraint to uk_alert_dedup (sign) across all three dialects and the 3.5.0 upgrade scripts, and also dropped the now-redundant idx_sign index on the same column since the unique index fully covers it (the drop runs after the unique index is created, so a failed upgrade leaves idx_sign in place). Dedup behavior is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
