njnu-seafish commented on PR #18549: URL: https://github.com/apache/dolphinscheduler/pull/18549#issuecomment-6123807111
@SbloodyS @ruanwenjun Both points addressed — thanks for the review. 1. Scope alert deduplication without suppressing subsequent server outages As agreed offline with you we went one step further and dropped the unique index entirely: uk_alert_dedup is removed and idx_sign stays as-is, so the t_ds_alert schema is identical to dev (63664d947e). The insertAlertWhenServerCrash suppression window is untouched, and occasional duplicate rows from repeated success events are accepted as-is. That path is unchanged baseline behavior. 3. Bound the serialized alert payload by bytes Addressed in 4f53d83e93: the alert content is now bounded to 60000 serialized UTF-8 bytes (a margin under the 65535-byte TEXT capacity). Rows are dropped from the tail until it fits; a row that alone exceeds the budget is replaced by the omission marker, keeping the payload a valid JSON array with an explicit truncation notice. Covered wide rows, multibyte text, and nested values in SqlTaskTest. Also, the three limits are now configurable via sql.task.alert.* in common.properties (eb286243c0) — this lands in this PR rather than a follow-up as mentioned earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
