yangyichao-mango commented on a change in pull request #3385:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464259230
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
##########
@@ -391,7 +391,12 @@ private Constants() {
public static final int RPC_PORT = 50051;
/**
- * forbid running task
+ * task can be run normally
+ */
+ public static final String FLOWNODE_RUN_FLAG_NORMAL = "NORMAL";
Review comment:
Hi,
Good job, but there is no necessary to add the `FLOWNODE_RUN_FLAG_NORMAL` in
Constants just for test case.
If you want to add the constant, you can directly add
`FLOWNODE_RUN_FLAG_NORMAL` in `ConditionsTaskTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
