[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3385: [Improvement][common,dao,server] unit test for ConditionsTask

[GitBox]

yangyichao-mango commented on a change in pull request #3385:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3385#discussion_r464268239



##########
File path: 
dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/ConditionsTaskTest.java
##########
@@ -17,7 +17,16 @@
 package org.apache.dolphinscheduler.server.master;

Review comment:
       Hi,
   I checkout to your branch and found that the `ConditionsTaskTest.java` is 
not in the test case includer.
   Please add the test to root pom.
   
![image](https://user-images.githubusercontent.com/29545877/89162341-8328d480-d5a6-11ea-9fec-d895d57e44cc.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org