yangyichao-mango commented on a change in pull request #3415:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3415#discussion_r466093575
##########
File path:
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ResourceMapperTest.java
##########
@@ -76,8 +76,10 @@ private Resource insertOne(){
resource.setDirectory(false);
resource.setType(ResourceType.FILE);
resource.setUserId(111);
- resourceMapper.insert(resource);
- return resource;
+ if( resourceMapper.insert(resource)>0 ){
+ return resource;
+ }
+ throw new RuntimeException("insert data error");
Review comment:
I also think assert.fail() is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
