CalvinKirs commented on pull request #3415: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3415#issuecomment-669896945
Thanks for your review, I will finish it later On 08/6/2020 09:32，Yichao Yang<[email protected]> wrote： @yangyichao-mango commented on this pull request. In dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ResourceMapperTest.java: > @@ -76,8 +76,10 @@ private Resource insertOne(){ resource.setDirectory(false); resource.setType(ResourceType.FILE); resource.setUserId(111); - resourceMapper.insert(resource); - return resource; + if( resourceMapper.insert(resource)>0 ){ + return resource; + } + throw new RuntimeException("insert data error"); I also think assert.fail() is better. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
