yangyichao-mango commented on a change in pull request #3470:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3470#discussion_r469052639
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java
##########
@@ -152,7 +152,7 @@ public void unRegistry() {
// trim and lower case is need
workerZkPathBuilder.append(workGroup.trim().toLowerCase()).append(SLASH);
workerZkPathBuilder.append(address);
- workerZkPathBuilder.append(weight).append(SLASH);
+ workerZkPathBuilder.append(weight);
Review comment:
@CalvinKirs Please check if remove this SLASH, will the weight load
balance produce error?
I understand that ZK path is only used to distinguish workers. We only need
to use host and port to uniquely determine a worker. If we add weight
information, the following situations may occur:
ds/worker/default/122.2.2.2:1:100
ds/worker/default/122.2.2.2:1:200
So will it better to add the weight to heartbeatinfo, not in the zk path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
