CalvinKirs commented on a change in pull request #3470:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3470#discussion_r469110994
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java
##########
@@ -152,7 +152,7 @@ public void unRegistry() {
// trim and lower case is need
workerZkPathBuilder.append(workGroup.trim().toLowerCase()).append(SLASH);
workerZkPathBuilder.append(address);
- workerZkPathBuilder.append(weight).append(SLASH);
+ workerZkPathBuilder.append(weight);
Review comment:
It is not very good to put in heartbeatinfo, maybe we should extract all
the metadata information and report it to zk separately, which may be better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
