CalvinKirs edited a comment on pull request #4140:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4140#issuecomment-738528829


   > > > @CalvinKirs When a new task put into the `queue`, sleep one second 
will make the comsumer waiting util one second pass.
   > > > But use `poll(timeout,Unit)` can solve this question, and can have 
some performance promote when the Tasks comes low frequency.
   > > > Also it can resolve that an always failed high-priority task block 
master consumer.
   > > > Queue implement used here is `PriorityBlockingQueue` , and 
poll(timeout,Unit) belongs to `PriorityBlockingQueue` .
   > > 
   > > 
   > > Sorry, I think you can do this.
   > 
   > Can not do this ?
   
   You can do as you said, sounds good to me, btw, code style check fail, you 
can refer to this article to complete the modification 
https://dolphinscheduler.apache.org/zh-cn/docs/development/pull -request.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to