dailidong commented on pull request #4140:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4140#issuecomment-743746166


   @GitFireMan , good first contribution,  your implemention is better,  I like 
this.  
   by the way, this PR need to do update following the doc : 
https://dolphinscheduler.apache.org/zh-cn/docs/development/pull -request.html,  
because the code-style not unify, and please solve confilct files locally
   
   
![image](https://user-images.githubusercontent.com/15833811/101983271-f8bf5280-3cb4-11eb-869d-6cd542f6e774.png)
   
   if you need any help , please contact me([email protected] or 
wechat:510570367) , when added, please tell me your github id
   
   you have done good job, let's make it better
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to