deanwong commented on a change in pull request #4372:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4372#discussion_r552805230
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java
##########
@@ -149,6 +149,33 @@ public static void setInParameter(int index,
PreparedStatement stmt, DataType da
}
}
+ /**
+ * curing user define parameters
+ *
+ * @param globalParamMap global param map
+ * @param globalParamList global param list
+ * @param commandType command type
+ * @param scheduleTime schedule time
+ * @param startParams start param map
+ * @return curing user define parameters
+ */
+ public static String curingGlobalParams(Map<String, String>
globalParamMap, List<Property> globalParamList,
+ CommandType commandType, Date
scheduleTime, Map<String, String> startParams) {
+ String globalParamsJson = curingGlobalParams(globalParamMap,
globalParamList, commandType, scheduleTime);
+ // merge start params
+ if (startParams != null && startParams.size() > 0) {
Review comment:
I think the startup params should be fixed values. If the UI exists, the
popup will let user input fixed value, and the fixed value pass into global
param. User can set variables in global params, but why does he set the
variables in start params?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
