chengshiwen commented on a change in pull request #4372:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4372#discussion_r554563346



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
##########
@@ -107,7 +108,8 @@ public Result startProcessInstance(@ApiIgnore 
@RequestAttribute(value = Constant
                                        @RequestParam(value = "runMode", 
required = false) RunMode runMode,
                                        @RequestParam(value = 
"processInstancePriority", required = false) Priority processInstancePriority,
                                        @RequestParam(value = "workerGroup", 
required = false, defaultValue = "default") String workerGroup,
-                                       @RequestParam(value = "timeout", 
required = false) Integer timeout) throws ParseException {
+                                       @RequestParam(value = "timeout", 
required = false) Integer timeout,
+                                       @RequestParam(value = "startParams", 
required = false) String startParams) throws ParseException {
         logger.info("login user {}, start process instance, project name: {}, 
process definition id: {}, schedule time: {}, "
                         + "failure policy: {}, node name: {}, node dep: {}, 
notify type: {}, "
                         + "notify group id: {},receivers:{},receiversCc:{}, 
run mode: {},process instance priority:{}, workerGroup: {}, timeout: {}",

Review comment:
       It would be better to print the `startParams`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to