chengshiwen commented on a change in pull request #4441:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4441#discussion_r560946275
##########
File path: dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js
##########
@@ -211,8 +211,13 @@ export default {
'Edit alarm group': 'Edit alarm group',
'Create alarm group': 'Create alarm group',
'Group Name': 'Group Name',
+ 'Create Alarm Instance': 'Create Alarm Instance',
Review comment:
In `en_US.js` and `zh_CN.js`, it would be better to keep one-to-one
correspondence line by line.
For `The os tenant code cannot be all numbers` at line 195 in `en_US.js`,
the line should be removed.
And then, the order of `Create Alarm Instance`, `Edit Alarm Instanc` and
`Alarm instance name` should be same with `zh_CN.js`
Similarly, there is a pair of `Tenant Name` and `Queue `.
##########
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/warningInstance/index.vue
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+<template>
+ <m-list-construction :title="$t('Warning instance manage')">
+ <template slot="conditions">
+ <m-conditions @on-conditions="_onConditions">
+ <template slot="button-group" v-if="isADMIN">
+ <el-button size="mini" @click="_create('')">{{$t('Create Alarm
Instance')}}</el-button>
+ <el-dialog
+ :visible.sync="createWarningDialog"
+ width="45%">
Review comment:
The `width` should be `auto`, otherwise widescreen problem will occur.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
