chengshiwen commented on a change in pull request #4441:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4441#discussion_r560946275
##########
File path: dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js
##########
@@ -211,8 +211,13 @@ export default {
'Edit alarm group': 'Edit alarm group',
'Create alarm group': 'Create alarm group',
'Group Name': 'Group Name',
+ 'Create Alarm Instance': 'Create Alarm Instance',
Review comment:
In `en_US.js` and `zh_CN.js`, it would be better to keep one-to-one
correspondence line by line.
The`The os tenant code cannot be all numbers` at line 195 in `en_US.js`
should be removed.
And then, the order of `Create Alarm Instance`, `Edit Alarm Instanc` and
`Alarm instance name` should be same with `zh_CN.js`
Similarly, there is also a pair of `Tenant Name` and `Queue `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
