chengshiwen commented on a change in pull request #4567:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4567#discussion_r565334995
##########
File path: dolphinscheduler-server/src/main/resources/logback-worker.xml
##########
@@ -56,10 +56,6 @@
</appender>
<appender name="WORKERLOGFILE"
class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>${log.base}/dolphinscheduler-worker.log</file>
- <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
- <level>INFO</level>
- </filter>
- <filter
class="org.apache.dolphinscheduler.server.log.WorkerLogFilter"/>
Review comment:
I see it.
It's better to remove or comment all `ThresholdFilter` configuration in
`logback-master.xml` and `logback-worker.xml` instead of removing one in
`logback-worker.xml`.
Good job, thx
##########
File path: dolphinscheduler-server/src/main/resources/logback-worker.xml
##########
@@ -56,10 +56,6 @@
</appender>
<appender name="WORKERLOGFILE"
class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>${log.base}/dolphinscheduler-worker.log</file>
- <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
- <level>INFO</level>
- </filter>
- <filter
class="org.apache.dolphinscheduler.server.log.WorkerLogFilter"/>
Review comment:
I see it.
It's better to remove or comment all `ThresholdFilter` configurations in
`logback-master.xml` and `logback-worker.xml` instead of removing one in
`logback-worker.xml`.
Good job, thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
