chengshiwen commented on a change in pull request #4567:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4567#discussion_r565806752
##########
File path: dolphinscheduler-server/src/main/resources/logback-worker.xml
##########
@@ -56,10 +56,9 @@
</appender>
<appender name="WORKERLOGFILE"
class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>${log.base}/dolphinscheduler-worker.log</file>
- <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
+ <!-- <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
- </filter>
- <filter
class="org.apache.dolphinscheduler.server.log.WorkerLogFilter"/>
Review comment:
I still have a question that is it a good way to remove
`WorkerLogFilter`. Removing `WorkerLogFilter` directly makes `WorkerLogFilter`
unavailable, so can we modify `WorkerLogFilter` to achieved the goal?
```
public FilterReply decide(ILoggingEvent event) {
if (event.getThreadName().startsWith("Worker-")){
return FilterReply.ACCEPT;
}
return FilterReply.DENY;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
