lenboo commented on a change in pull request #4678:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4678#discussion_r571343565



##########
File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
##########
@@ -540,13 +545,49 @@ private TaskInstance createTaskInstance(ProcessInstance 
processInstance, String
             } else {
                 taskInstance.setWorkerGroup(taskWorkerGroup);
             }
-
+            //get process global
+            String globalParams = this.processInstance.getGlobalParams();

Review comment:
       extract to a method  is helpful for reducing complexity 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to