lenboo commented on a change in pull request #4678:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4678#discussion_r571580676
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -686,11 +691,14 @@ private ProcessInstance constructProcessInstance(Command
command, String host) {
} else {
processInstance =
this.findProcessInstanceDetailById(processInstanceId);
// Recalculate global parameters after rerun.
-
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
- processDefinition.getGlobalParamMap(),
- processDefinition.getGlobalParamList(),
- getCommandTypeIfComplement(processInstance, command),
- processInstance.getScheduleTime()));
+ //if the CommandType is start from fail task note,the
globalparam can't be cover
+ if (commandType != CommandType.START_FAILURE_TASK_PROCESS) {
+
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
Review comment:
all the recovery operation need this, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
