wangxj3 commented on a change in pull request #4743:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4743#discussion_r578321952



##########
File path: 
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java
##########
@@ -221,4 +221,7 @@ ProcessInstance 
queryLastManualProcess(@Param("processDefinitionId") int definit
             @Param("processDefinitionId") int processDefinitionId,
             @Param("states") int[] states);
 
+    int updateGlobalParamById(

Review comment:
       I will fix it ,thank you.

##########
File path: 
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
##########
@@ -219,5 +219,9 @@
         </foreach>
         order by id asc
     </select>
-
+    <update id="updateGlobalParamById">

Review comment:
       I will fix it ,thank you.

##########
File path: 
dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/TaskExecuteResponseCommand.java
##########
@@ -68,7 +68,10 @@ public TaskExecuteResponseCommand(int taskInstanceId) {
      * varPool string
      */
     private String varPool;
-
+    /**
+     * task return result
+     */
+    private String result;
     public void setVarPool(String varPool) {

Review comment:
       I will fix it ,thank you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to