wangxj3 commented on a change in pull request #4743:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4743#discussion_r578975188
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -686,11 +691,6 @@ private ProcessInstance constructProcessInstance(Command
command, String host) {
} else {
processInstance =
this.findProcessInstanceDetailById(processInstanceId);
// Recalculate global parameters after rerun.
-
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
- processDefinition.getGlobalParamMap(),
- processDefinition.getGlobalParamList(),
- getCommandTypeIfComplement(processInstance, command),
- processInstance.getScheduleTime()));
Review comment:
we think the process globalParams should be reset if the commandType is
in 'START_PROCESS','SCHEDULER','REPEAT_RUNNING'.those commandType will reset
its globalParams in the part of 'switch'
The process globalParams should Keep the original value if the commandType
in 'START_CURRENT_TASK_PROCESS' ,'START_FAILURE_TASK_PROCESS' ,and other
commandType like the process does not start from the start node,so the
globalParams shouldn't be reset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
