wen-hemin commented on a change in pull request #4743:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/4743#discussion_r580827702



##########
File path: 
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -686,11 +691,6 @@ private ProcessInstance constructProcessInstance(Command 
command, String host) {
             } else {
                 processInstance = 
this.findProcessInstanceDetailById(processInstanceId);
                 // Recalculate global parameters after rerun.
-                
processInstance.setGlobalParams(ParameterUtils.curingGlobalParams(
-                    processDefinition.getGlobalParamMap(),
-                    processDefinition.getGlobalParamList(),
-                    getCommandTypeIfComplement(processInstance, command),
-                    processInstance.getScheduleTime()));

Review comment:
       I don't see different processing according to the commandtype




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to