chengshiwen commented on a change in pull request #4806:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4806#discussion_r582130365
##########
File path: sql/dolphinscheduler_mysql.sql
##########
@@ -703,7 +703,7 @@ CREATE TABLE `t_ds_task_instance` (
`alert_flag` tinyint(4) DEFAULT NULL COMMENT 'whether alert',
`retry_times` int(4) DEFAULT '0' COMMENT 'task retry times',
`pid` int(4) DEFAULT NULL COMMENT 'pid of task',
- `app_link` text COMMENT 'yarn app id',
+ `app_link` varchar(255) DEFAULT NULL COMMENT 'yarn app id',
Review comment:
But in `1.3.5-release`, `app_link` is `varchar(255)` with link
[https://github.com/apache/incubator-dolphinscheduler/blob/1.3.5-release/sql/dolphinscheduler_mysql.sql#L704](https://github.com/apache/incubator-dolphinscheduler/blob/1.3.5-release/sql/dolphinscheduler_mysql.sql#L704),
I just keep it same as `1.3.5-release`. If `app_link` needs to be set to
`text`, it's better in `1.3.6-release`, and the dev branch just merges the
`1.3.6-release`. Or I just update `upgrade/1.4.0-schema` in dev branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
