chengshiwen commented on a change in pull request #4806:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/4806#discussion_r582130365
##########
File path: sql/dolphinscheduler_mysql.sql
##########
@@ -703,7 +703,7 @@ CREATE TABLE `t_ds_task_instance` (
`alert_flag` tinyint(4) DEFAULT NULL COMMENT 'whether alert',
`retry_times` int(4) DEFAULT '0' COMMENT 'task retry times',
`pid` int(4) DEFAULT NULL COMMENT 'pid of task',
- `app_link` text COMMENT 'yarn app id',
+ `app_link` varchar(255) DEFAULT NULL COMMENT 'yarn app id',
Review comment:
I know what goes wrong.
In `1.3.5-release/sql/upgrade/1.3.0_schema/mysql/dolphinscheduler_ddl.sql`
([link](https://github.com/apache/incubator-dolphinscheduler/blob/1.3.5-release/sql/upgrade/1.3.0_schema/mysql/dolphinscheduler_ddl.sql#L59))
and
`1.3.5-release/sql/upgrade/1.3.0_schema/postgresql/dolphinscheduler_ddl.sql`
([link](https://github.com/apache/incubator-dolphinscheduler/blob/1.3.5-release/sql/upgrade/1.3.0_schema/postgresql/dolphinscheduler_ddl.sql#L53)),
the type of `app_link` has been updated to `text`,
But in `1.3.5-release/sql/dolphinscheduler_mysql.sql`
([link](https://github.com/apache/incubator-dolphinscheduler/blob/1.3.5-release/sql/dolphinscheduler_mysql.sql#L704))
and `1.3.5-release/sql/dolphinscheduler-postgre.sql`
([link](https://github.com/apache/incubator-dolphinscheduler/blob/1.3.5-release/sql/dolphinscheduler-postgre.sql#L565)),
`app_link` is still `varchar(255)`.
To keep dev branch same as `1.3.5-release`, I just copy upgrade schemas to
dev branch from 1.3.5-release.
There also is a problem that `app_link` isn't updated to `text` in
`dev/sql/dolphinscheduler-postgre.sql`
([link](https://github.com/apache/incubator-dolphinscheduler/blob/dev/sql/dolphinscheduler-postgre.sql#L571))
For the problems, I have updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
