chengshiwen commented on a change in pull request #5019:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5019#discussion_r595697442
##########
File path: docker/kubernetes/dolphinscheduler/values.yaml
##########
@@ -76,12 +76,12 @@ common:
- "export HADOOP_CONF_DIR=/opt/soft/hadoop/etc/hadoop"
- "export SPARK_HOME1=/opt/soft/spark1"
- "export SPARK_HOME2=/opt/soft/spark2"
- #- "export PYTHON_HOME=/opt/soft/python"
+ - "export PYTHON_HOME=/usr"
- "export JAVA_HOME=/usr/lib/jvm/java-1.8-openjdk"
- "export HIVE_HOME=/opt/soft/hive"
- "export FLINK_HOME=/opt/soft/flink"
- - "export DATAX_HOME=/opt/soft/datax/bin/datax.py"
- - "export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$FLINK_HOME/bin:$PATH"
+ - "export DATAX_HOME=/opt/soft/datax"
+ - "export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$FLINK_HOME/bin:$DATAX_HOME/bin:$PATH"
Review comment:
Just keep consistency with other `dolphinscheduler_env.sh`. In fact,
none of these environment variables such as `SPARK_HOME1`, `SPARK_HOME2`,
`PYTHON_HOME` and `DATAX_HOME` in `PATH` are needed. In future, I will give a
refactoring for the `HOME` environment variables, please refer to #5035. We
don’t need the PATH environment variable at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
