chengshiwen commented on a change in pull request #5019:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5019#discussion_r595697470
##########
File path: docker/build/conf/dolphinscheduler/env/dolphinscheduler_env.sh.tpl
##########
@@ -25,4 +25,4 @@ export HIVE_HOME=$HIVE_HOME
export FLINK_HOME=$FLINK_HOME
export DATAX_HOME=$DATAX_HOME
-export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$PATH:$FLINK_HOME/bin:$DATAX_HOME:$PATH
+export
PATH=$HADOOP_HOME/bin:$SPARK_HOME1/bin:$SPARK_HOME2/bin:$PYTHON_HOME/bin:$JAVA_HOME/bin:$HIVE_HOME/bin:$FLINK_HOME/bin:$DATAX_HOME/bin:$PATH
Review comment:
Just keep consistency with other `dolphinscheduler_env.sh`. In fact,
none of these environment variables such as `SPARK_HOME1`, `SPARK_HOME2`,
`PYTHON_HOME` and `DATAX_HOME` in `PATH` are needed. In future, I will give a
refactoring for the `HOME` environment variables, please refer to #5035. We
don’t need the PATH environment variable at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
