[GitHub] [incubator-dolphinscheduler] lyyprean opened a new issue #5147: [Improvement][Master] this expression which always evaluates "true"

[GitBox]

lyyprean opened a new issue #5147:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/5147


   *For better global communication, please give priority to using English 
description, thx! *
   
   *Please review 
https://dolphinscheduler.apache.org/en-us/community/development/issue.html when 
describe an issue.*
   
   **Describe the question**
   this expression which always evaluates "true"
   
   **What are the current deficiencies and the benefits of improvement**
   this expression which always evaluates "true" ，removeTaskLogFile  method of 
org.apache.dolphinscheduler.service.process
   
   **Which version of DolphinScheduler:**
    -[1.3.5]
   
   **Describe alternatives you've considered**
   public void removeTaskLogFile(Integer processInstanceId) {
   
           LogClientService logClient = null;
   
           try {
               logClient = new LogClientService();
               List<TaskInstance> taskInstanceList = 
findValidTaskListByProcessId(processInstanceId);
   
               if (CollectionUtils.isEmpty(taskInstanceList)) {
                   return;
               }
   
               for (TaskInstance taskInstance : taskInstanceList) {
                   String taskLogPath = taskInstance.getLogPath();
                   if (StringUtils.isEmpty(taskInstance.getHost())) {
                       continue;
                   }
                   int port = Constants.RPC_PORT;
                   String ip = "";
                   try {
                       ip = Host.of(taskInstance.getHost()).getIp();
                   } catch (Exception e) {
                       // compatible old version
                       ip = taskInstance.getHost();
                   }
   
                   // remove task log from loggerserver
                   logClient.removeTaskLog(ip, port, taskLogPath);
               }
           } finally {
    
                   logClient.close();
               
           }
       }
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org