[GitHub] [incubator-dolphinscheduler] zhuangchong commented on issue #5147: [Improvement][Master] this expression which always evaluates "true"

[GitBox]

zhuangchong commented on issue #5147:
URL: 
https://github.com/apache/incubator-dolphinscheduler/issues/5147#issuecomment-806578506


   @lyyprean 
   I suggest to change it like this
   
   ```
   LogClientService logClient = null;
   
     
          
           List<TaskInstance> taskInstanceList = 
findValidTaskListByProcessId(processInstanceId);
   
           if (CollectionUtils.isEmpty(taskInstanceList)) {
               return;
           }
   
     try {
        logClient = new LogClientService();
           for (TaskInstance taskInstance : taskInstanceList) {
               String taskLogPath = taskInstance.getLogPath();
               if (StringUtils.isEmpty(taskInstance.getHost())) {
                   continue;
               }
               int port = Constants.RPC_PORT;
               String ip = "";
               try {
                   ip = Host.of(taskInstance.getHost()).getIp();
               } catch (Exception e) {
                   // compatible old version
                   ip = taskInstance.getHost();
               }
   
               // remove task log from loggerserver
               logClient.removeTaskLog(ip, port, taskLogPath);
           }
       } finally {
   
              if (logClient != null) {
               logClient.close();
           }
           
       }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org