wen-hemin commented on a change in pull request #5246:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/5246#discussion_r611144165
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskExecuteProcessor.java
##########
@@ -133,7 +133,6 @@ public void process(Channel channel, Command command) {
setTaskCache(taskExecutionContext);
// custom logger
Logger taskLogger =
LoggerFactory.getLogger(LoggerUtils.buildTaskId(LoggerUtils.TASK_LOGGER_INFO_PREFIX,
- taskExecutionContext.getProcessDefineId(),
Review comment:
It is suggested to modify it to be consistent with the log path rule
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/LoggerUtils.java
##########
@@ -67,20 +67,15 @@ private LoggerUtils() {
* build job id
*
* @param affix Task Logger's prefix
- * @param processDefId process define id
* @param processInstId process instance id
* @param taskId task id
* @return task id format
*/
public static String buildTaskId(String affix,
- int processDefId,
int processInstId,
int taskId) {
// - [taskAppId=TASK_79_4084_15210]
- return String.format(" - %s%s-%s-%s-%s]", TASK_APPID_LOG_FORMAT, affix,
- processDefId,
- processInstId,
- taskId);
+ return String.format(" - %s%s-%s-%s]", TASK_APPID_LOG_FORMAT, affix,
processInstId, taskId);
Review comment:
It is suggested to modify it to be consistent with the log path rule.
It is convenient to debug through log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
