JinyLeeChina commented on a change in pull request #5246:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/5246#discussion_r611153111



##########
File path: 
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/LoggerUtils.java
##########
@@ -67,20 +67,15 @@ private LoggerUtils() {
      * build job id
      *
      * @param affix Task Logger's prefix
-     * @param processDefId process define id
      * @param processInstId process instance id
      * @param taskId task id
      * @return task id format
      */
     public static String buildTaskId(String affix,
-                                     int processDefId,
                                      int processInstId,
                                      int taskId) {
         // - [taskAppId=TASK_79_4084_15210]
-        return String.format(" - %s%s-%s-%s-%s]", TASK_APPID_LOG_FORMAT, affix,
-                processDefId,
-                processInstId,
-                taskId);
+        return String.format(" - %s%s-%s-%s]", TASK_APPID_LOG_FORMAT, affix, 
processInstId, taskId);

Review comment:
       This is taskAppId, not log path




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to