zhuangchong commented on pull request #5387:
URL: https://github.com/apache/dolphinscheduler/pull/5387#issuecomment-826620822


   > > I don't think it's a problem.If you want to improve the user experience, 
you should provide detection during the first deployment.
   > 
   > I have tried other ways and find out no better way. At present, it is the 
best way to check the table in `alert-server` and it's very simple. A good 
program should manage its dependencies.
   > I don't want to spend too much time explaining to new users why the 
`alert-server` will cause startup failures in **docker/k8s one-click 
deployment**. Just a few lines of code can solve this problem well, why are we 
bothered by it?
   > **One-click deployment** is equivalent to **the first deployment**. You 
can try to deploy ds by docker or k8s and tell me the better way.
   
   A good program should manage its dependencies. What's more, it should check 
all the dependencies before the program starts. If there is a problem with the 
dependencies, it will directly truncate and prompt the user
   
   In order to deploy docker / k8s with one click, cycle to check whether the 
plugin table exists. The one click deployment is successful, and the alert 
function in alert server is not really started. (in order to deploy with one 
click, others can be hidden?) This will also cause some users to think that the 
deployment has been successful and they can't receive the alarm. Maybe they 
find that the plugin table doesn't exist because they haven't received the 
alarm. This is not as good as the current way. When deploying, errors will be 
displayed, and users will solve this problem.
   
   ---
   
   一个好的程序是应该管理其依赖项, 那更应该做的是在程序启动前检查所有依赖项,依赖项存在问题,直接截断提示用户。
   
   为了docker / 
k8s一键部署,循环检测plugin表是否存在,一键部署是成功了,alert-server内告警功能并没有真正启动,(为了可以一键部署,其他都可以隐藏?)这也会造成一部分用户认为已经部署成功,接收不到告警,也许发现plugin表不存在是因为没有收到告警。这样还不如现在的方式,在部署的时候就显示错误,用户就会解决这个问题。
 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to