chengshiwen edited a comment on pull request #5387:
URL: https://github.com/apache/dolphinscheduler/pull/5387#issuecomment-826631293
@zhuangchong Do you know what I'm talking about?
**When `t_ds_plugin_define` does not exist, does the `alert-server` program
have any meaning? Can it send alerts?**
In your words, it seems that `runSender` and `logger.warn("No Alert Plugin.
Cannot send alert info. ")` are unnecessary, right?
https://github.com/apache/dolphinscheduler/blob/6b8461e901de65000f4f8f34ebfe011946e787d3/dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java#L122-L138
**Do not spend much time arguing about this, maybe it's better to solve the
backlog of issues or prs. Do not think about these things as a programmer,
please.**
**One more thing, if possible, please think about these things from a global
perspective, such as deployment and maintainability, otherwise, the software
will be difficult to use**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
