blackberrier commented on pull request #5572:
URL: https://github.com/apache/dolphinscheduler/pull/5572#issuecomment-857336870


   > LGTM, can you write some unit tests, the coverage is 0 now.
   
   @ruanwenjun 
   Hi, I've added some unit tests for `TaskInstanceCacheManagerImpl`. Please 
review it for me. Thx.
   By the way, while I am working on this, I have found a bug in 
`cacheTaskInstance(TaskExecuteResponseCommand taskExecuteResponseCommand)` 
method , and I have fixed it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to