ruanwenjun commented on a change in pull request #5572:
URL: https://github.com/apache/dolphinscheduler/pull/5572#discussion_r647935369



##########
File path: 
dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/cache/impl/TaskInstanceCacheManagerImplTest.java
##########
@@ -0,0 +1,160 @@
+package org.apache.dolphinscheduler.server.master.cache.impl;

Review comment:
       You need to add Apache license header here, you can find the license 
header in other file.
   And when you add an ut file, you need to add the test class in root pom.xml 
like below:
   ```java
   <include>**/api/service/MonitorServiceTest.java</include>
   <include>**/api/service/ProcessDefinitionServiceTest.java</include>
   <include>**/api/service/ProcessTaskRelationServiceImplTest.java</include>
   <include>**/api/service/TaskDefinitionServiceImplTest.java</include>
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to