ruanwenjun commented on a change in pull request #5983:
URL: https://github.com/apache/dolphinscheduler/pull/5983#discussion_r690946385
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -131,7 +131,7 @@ Result queryProcessInstanceList(User loginUser, String
projectName, Integer proc
* @param processInstanceId process instance id
* @return delete result code
*/
- Map<String, Object> deleteProcessInstanceById(User loginUser, String
projectName, Integer processInstanceId);
+ Map<String, Object> deleteProcessInstanceById(User loginUser, String
projectName, Integer processInstanceId, Map<String, List<String>> taskFiles);
Review comment:
Can we remove the `taskFIles` in params and return this in the result
##########
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/MapUtils.java
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.common.utils;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+public class MapUtils {
+
+ public static void combineMap(Map<String, List<String>> originMap,
Review comment:
It's better to rename this method to putAll, sometimes combine may not a
side effect method, if you want to use combineMap, you would better add a
return value of the method.
And it's better to use generics type here.
```java
public static <K, V> void putAll(Map<K, V> originMap, Map<K, V> putMap,
BiFunction<V, V, V> combineFunction) {
if (originMap == null) {
originMap = new HashMap<>();
}
if (MapUtils.isEmpty(putMap)) {
return;
}
for (Map.Entry<K, V> entry : putMap.entrySet()) {
K key = entry.getKey();
V newValue = combineFunction.apply(originMap.get(key),
entry.getValue());
originMap.put(key, newValue);
}
}
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
