ruanwenjun commented on a change in pull request #5983:
URL: https://github.com/apache/dolphinscheduler/pull/5983#discussion_r691142485
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java
##########
@@ -131,7 +131,7 @@ Result queryProcessInstanceList(User loginUser, String
projectName, Integer proc
* @param processInstanceId process instance id
* @return delete result code
*/
- Map<String, Object> deleteProcessInstanceById(User loginUser, String
projectName, Integer processInstanceId);
+ Map<String, Object> deleteProcessInstanceById(User loginUser, String
projectName, Integer processInstanceId, Map<String, List<String>> taskFiles);
Review comment:
No problem, it may be programing habit, sometimes if a method return
results, then it shouldn't be side effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
