[GitHub] [dolphinscheduler] LiuBodong commented on a change in pull request #6222: [Fix-6220] [API] New tenant name could be "default"

Wed, 15 Sep 2021 23:02:54 -0700 


LiuBodong commented on a change in pull request #6222:
URL: https://github.com/apache/dolphinscheduler/pull/6222#discussion_r709803293



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TenantServiceImpl.java
##########
@@ -95,7 +95,8 @@
             return result;
         }
 
-        if (checkTenantExists(tenantCode)) {
+        // check if tenant exists in database or named "default"
+        if (checkTenantExists(tenantCode) || 
"default".equalsIgnoreCase(tenantCode)) {

Review comment:
       
![图片](https://user-images.githubusercontent.com/23203149/133557913-946ed17e-e519-4a5f-8dae-9e9f0525ddc9.png)
   
   There's already a tenant named "default" which is a default tenant if no 
other tenant could be chosen, if we create a new tenant named "default", it 
hard to figure out which one is the "real" tenant we need.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to