JinyLeeChina commented on a change in pull request #6222:
URL: https://github.com/apache/dolphinscheduler/pull/6222#discussion_r709937116



##########
File path: 
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TenantServiceImpl.java
##########
@@ -95,7 +95,8 @@
             return result;
         }
 
-        if (checkTenantExists(tenantCode)) {
+        // check if tenant exists in database or named "default"
+        if (checkTenantExists(tenantCode) || 
"default".equalsIgnoreCase(tenantCode)) {

Review comment:
       I have different suggestion. if the user want to create a workflow when 
no tenant exists, in order not to affect workflow creation the tenant id will 
be -1, and now the tenant code is 'default'. I think that's how default appears.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to