EricPyZhou opened a new pull request #6283:
URL: https://github.com/apache/dolphinscheduler/pull/6283


   <!--Thanks very much for contributing to Apache DolphinScheduler. Please 
review 
https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
 before opening a pull request.-->
   
   
   ## Purpose of the pull request
   Remove JsonUtils.toMap method that supported generic types based on previous 
discussions. replace the existing invocation with parseObject(String json, 
TypeReference type)
   
   Fix bug #6072 
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   Remove the generic method `JsonUtils.toMap` in JSONUtils.java
   Modified the testcase `testToMap` to adopt the change above
   
   Remove `JsonUtils.toMap` in `ProcessService.java` , `TaskNode.java`, 
`ExecutorServiceImpl.java`, `TaskInstance.java` and replaced by 
`parseObject(String json, TypeReference type)`
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   `testChangeOutParam` in `ProcessServiceTest.java`
   `testParsePostNodeList` in `DagHelperTest.java`
   `testExecuteRepeatRunning` in `ExecutorServiceTest.java`
   `testTaskInstanceGetDependence` in `TaskInstanceTest.java`
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to