EricPyZhou commented on a change in pull request #6283:
URL: https://github.com/apache/dolphinscheduler/pull/6283#discussion_r712694974



##########
File path: 
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/JSONUtilsTest.java
##########
@@ -199,8 +203,6 @@ public void testToMap() {
 
         Assert.assertNull(JSONUtils.toMap("3"));

Review comment:
       > Since we have remove the `JSONUtils.toMap` method, so this will 
compile failed.
   
   oh okay, I do think we can get rid of toMap by looking back to discussions. 
will do that and commit tomorrow. (It's midnight here in my time zone)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to