caishunfeng commented on a change in pull request #6485:
URL: https://github.com/apache/dolphinscheduler/pull/6485#discussion_r726002317



##########
File path: 
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerService.java
##########
@@ -165,15 +181,19 @@ public void run() {
      */
     private void scheduleProcess() throws Exception {
 
-        int activeCount = masterExecService.getActiveCount();
         // make sure to scan and delete command  table in one transaction
         Command command = findOneCommand();
         if (command != null) {
             logger.info("find one command: id: {}, type: {}", command.getId(), 
command.getCommandType());
             try {
                 ProcessInstance processInstance = 
processService.handleCommand(logger,
                         getLocalAddress(),
-                        this.masterConfig.getMasterExecThreads() - 
activeCount, command);
+                        command,
+                        processDefinitionCacheMaps);
+                if (!masterConfig.getMasterCacheProcessDefinition()

Review comment:
       Is it better to manage processDefinition cache by a unified manager? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to