lenboo commented on a change in pull request #6485:
URL: https://github.com/apache/dolphinscheduler/pull/6485#discussion_r726009788
##########
File path:
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java
##########
@@ -744,90 +735,74 @@ private Boolean checkCmdParam(Command command,
Map<String, String> cmdParam) {
/**
* construct process instance according to one command.
*
- * @param command command
- * @param host host
+ * @param command command
+ * @param host host
+ * @param processDefinitionCacheMaps
* @return process instance
*/
- private ProcessInstance constructProcessInstance(Command command, String
host) {
+ private ProcessInstance constructProcessInstance(Command command, String
host, HashMap<String, ProcessDefinition> processDefinitionCacheMaps) {
ProcessInstance processInstance;
+ ProcessDefinition processDefinition;
CommandType commandType = command.getCommandType();
- Map<String, String> cmdParam =
JSONUtils.toMap(command.getCommandParam());
-
- ProcessDefinition processDefinition =
getProcessDefinitionByCommand(command.getProcessDefinitionCode(), cmdParam);
+ String key = String.format("%d-%d",
command.getProcessDefinitionCode(), command.getProcessDefinitionVersion());
Review comment:
> Any other else? Or it just use for constructProcessInstance?
maybe the task definitions can also be cached
and a clean-up mechanism can also be added to the cache queue, eg: clean
cache queue once a day?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
