kezhenxu94 commented on a change in pull request #6322: URL: https://github.com/apache/dolphinscheduler/pull/6322#discussion_r756727943
########## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/AuditMessage.java ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.api.audit; + +import org.apache.dolphinscheduler.common.enums.AuditModuleType; +import org.apache.dolphinscheduler.common.enums.AuditOperationType; +import org.apache.dolphinscheduler.dao.entity.User; + +import java.util.Date; + +public class AuditMessage { + private User user; + + private Date auditDate; + + private AuditModuleType module; + + private AuditOperationType operation; + + private String projectName; + + private String processName; Review comment: The design of audit message looks bad, it includes the resources in it, so if we need to audit 100 kinds of resources (tenants, users, projects, workflows, workflow instances, ...), we have to put their `***Name` here? That would make the class explode and we have to modify the database schema over and over again, also there might be many fields empty (redundant) for many records. In my mind, an audit log should only include an operation (say, CRUD), a resource type (for example, project, workflow), and a resource id (project id, workflow id), with that we can expand the audit logs easily -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
