kezhenxu94 commented on a change in pull request #6322: URL: https://github.com/apache/dolphinscheduler/pull/6322#discussion_r757538338
########## File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/AuditMessage.java ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.api.audit; + +import org.apache.dolphinscheduler.common.enums.AuditModuleType; +import org.apache.dolphinscheduler.common.enums.AuditOperationType; +import org.apache.dolphinscheduler.dao.entity.User; + +import java.util.Date; + +public class AuditMessage { + private User user; + + private Date auditDate; + + private AuditModuleType module; + + private AuditOperationType operation; + + private String projectName; + + private String processName; Review comment: > Thanks for your review. > > Is it necessary to record the operator information and the operation time ? Yes we need > The resource id may include project id, workflow id ,datasource id and so on. The resouce id is a foreign key associated with different database tables. It may confused for user to see the resource id on the UI interface. We can query the resource by that id and display it on UI. It's always a trade off, because if we choose to save the name of the resource, when the name is modified (renamed) the user is also confused because they may sad they didn't operate that resource (but the fact is that they operate on the resource before they are renamed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
