kezhenxu94 commented on a change in pull request #8066:
URL: https://github.com/apache/dolphinscheduler/pull/8066#discussion_r785592658
##########
File path:
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/resources/docker/file-manage/docker-compose.yaml
##########
@@ -35,22 +35,51 @@ services:
volumes:
- ./common.properties:/opt/dolphinscheduler/conf/common.properties
depends_on:
- hdfs:
+ s3:
condition: service_healthy
- hdfs:
- image: mdouchement/hdfs:latest
- hostname: hdfs
+ mc:
+ condition: service_healthy
+ s3:
+ image: minio/minio:latest
+ hostname: s3
tty: true
stdin_open: true
- expose:
- - 8020
+ command: server /data --console-address ":9001"
+ ports:
+ - 9000:9000
networks:
- e2e
+ environment:
+ MINIO_ROOT_USER: accessKey123
+ MINIO_ROOT_PASSWORD: secretKey123
healthcheck:
- test: [ "CMD", "curl", "http://localhost:50070"; ]
+ test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live";]
interval: 5s
timeout: 120s
retries: 120
-
+ mc:
+ image: minio/mc:latest
+ entrypoint: ""
+ hostname: mc
+ tty: true
+ stdin_open: true
+ networks:
+ - e2e
+ command: bash -c '
+ mc alias set s3 http://s3:9000 accessKey123 secretKey123
+ && mc mb s3/dolphinscheduler && tail -f /dev/null'
Review comment:
If you do this, even if the command `bash -c xxxxxxx` failed I think
it's still considered as healthy because your health check command is `echo 1`.
You don't need health check for Init Containers, you can use something like
```yaml
dependes_on:
mc:
condition: service_completed_successfully
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
