SbloodyS commented on a change in pull request #8066:
URL: https://github.com/apache/dolphinscheduler/pull/8066#discussion_r785609344
##########
File path:
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/resources/docker/file-manage/docker-compose.yaml
##########
@@ -35,22 +35,51 @@ services:
volumes:
- ./common.properties:/opt/dolphinscheduler/conf/common.properties
depends_on:
- hdfs:
+ s3:
condition: service_healthy
- hdfs:
- image: mdouchement/hdfs:latest
- hostname: hdfs
+ mc:
+ condition: service_healthy
+ s3:
+ image: minio/minio:latest
+ hostname: s3
tty: true
stdin_open: true
- expose:
- - 8020
+ command: server /data --console-address ":9001"
+ ports:
+ - 9000:9000
networks:
- e2e
+ environment:
+ MINIO_ROOT_USER: accessKey123
+ MINIO_ROOT_PASSWORD: secretKey123
healthcheck:
- test: [ "CMD", "curl", "http://localhost:50070"; ]
+ test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live";]
interval: 5s
timeout: 120s
retries: 120
-
+ mc:
+ image: minio/mc:latest
+ entrypoint: ""
+ hostname: mc
+ tty: true
+ stdin_open: true
+ networks:
+ - e2e
+ command: bash -c '
+ mc alias set s3 http://s3:9000 accessKey123 secretKey123
+ && mc mb s3/dolphinscheduler && tail -f /dev/null'
Review comment:
```text
services.dolphinscheduler.depends_on.mc.condition contains
"service_completed_successfully", which is an invalid type, it should be a
service_started, or a service_healthy
```
Support for service_completed_successfully has been removed until added in
the latest version of docker-compose 1.29.
However, the built-in docker compose version of Ubuntu 20.04 is only 1.25 at
most. It seems that we can only use
service_healthy or service_started...
https://github.com/docker/compose/issues/8154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
