kezhenxu94 commented on code in PR #9944:
URL: https://github.com/apache/dolphinscheduler/pull/9944#discussion_r867579565
##########
dolphinscheduler-data-quality/pom.xml:
##########
@@ -171,34 +171,4 @@
</dependency>
</dependencies>
-
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-assembly-plugin</artifactId>
- <version>2.2</version>
- <configuration>
- <appendAssemblyId>false</appendAssemblyId>
- <descriptorRefs>
- <descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- <archive>
- <manifest>
-
<mainClass>org.apache.dolphinscheduler.data.quality.DataQualityApplication</mainClass>
- </manifest>
- </archive>
- </configuration>
- <executions>
- <execution>
- <id>make-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
Review Comment:
It doesn't make sense to me `jar-with-dependencies` packaging will improve
the packaging speed, please provide more details @zixi0825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
