kezhenxu94 commented on code in PR #9944:
URL: https://github.com/apache/dolphinscheduler/pull/9944#discussion_r867686013
##########
dolphinscheduler-data-quality/pom.xml:
##########
@@ -171,34 +171,4 @@
</dependency>
</dependencies>
-
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-assembly-plugin</artifactId>
- <version>2.2</version>
- <configuration>
- <appendAssemblyId>false</appendAssemblyId>
- <descriptorRefs>
- <descriptorRef>jar-with-dependencies</descriptorRef>
- </descriptorRefs>
- <archive>
- <manifest>
-
<mainClass>org.apache.dolphinscheduler.data.quality.DataQualityApplication</mainClass>
- </manifest>
- </archive>
- </configuration>
- <executions>
- <execution>
- <id>make-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
Review Comment:
> Jar-with-dependencies has nothing to do with improving packaging speed. I
only use this to make the data quality task easier to use. When running the
spark application, there is no need to add the paths of various drivers to
reduce errors. I will mention PR to remove jar-with-dependencies.
@zixi0825 Thank you, that make sense to me. How do you plan to remove
jar-with-dependencies, will that effect how users use this module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
