genuinner commented on code in PR #9955:
URL: https://github.com/apache/dolphinscheduler/pull/9955#discussion_r869023598
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -417,8 +417,12 @@ private boolean taskStateChangeHandler(StateEvent
stateEvent) {
}
if (activeTaskProcessorMaps.containsKey(task.getTaskCode())) {
ITaskProcessor iTaskProcessor =
activeTaskProcessorMaps.get(task.getTaskCode());
- iTaskProcessor.action(TaskAction.RUN);
-
+ // pending task needs to be dispatched
+ if (task.getState().typeIsPending()){
Review Comment:
hello, in dispatchFailedTaskInstanceState2Pending() method, you just save
the pending status to db but not in WorkflowExecuteThread.taskInstanceMap, i am
not sure if the task here that get from taskInstanceMap can be pending, or the
taskInstanceMap may update taskInstance other place ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
